fix: close http response object in java SDK (#110)

* fix: close http response object in java SDK * chore: fmt
flipt-io · Feb 15, 2024 · 9b23287 · 9b23287
1 parent bc1e7d2
commit 9b23287
Showing 1 changed file with 23 additions and 3 deletions.
diff --git a/flipt-java/src/main/java/io/flipt/api/evaluation/Evaluation.java b/flipt-java/src/main/java/io/flipt/api/evaluation/Evaluation.java
@@ -30,6 +30,7 @@ public Evaluation(
             .build();
   }
 
+  @SuppressWarnings("resource")
   public VariantEvaluationResponse evaluateVariant(EvaluationRequest request) {
     URL url;
 
@@ -41,8 +42,10 @@ public VariantEvaluationResponse evaluateVariant(EvaluationRequest request) {
 
     Request.Builder requestBuilder = makeRequest(request, url);
 
+    Response response = null;
+
     try {
-      Response response = httpClient.newCall(requestBuilder.build()).execute();
+      response = httpClient.newCall(requestBuilder.build()).execute();
       assert response.body() != null;
 
       if (!response.isSuccessful()) {
@@ -52,9 +55,14 @@ public VariantEvaluationResponse evaluateVariant(EvaluationRequest request) {
       return this.objectMapper.readValue(response.body().string(), VariantEvaluationResponse.class);
     } catch (IOException e) {
       throw new RuntimeException(e);
+    } finally {
+      if (response != null) {
+        response.close();
+      }
     }
   }
 
+  @SuppressWarnings("resource")
   public BooleanEvaluationResponse evaluateBoolean(EvaluationRequest request) {
     URL url;
 
@@ -66,8 +74,9 @@ public BooleanEvaluationResponse evaluateBoolean(EvaluationRequest request) {
 
     Request.Builder requestBuilder = makeRequest(request, url);
 
+    Response response = null;
     try {
-      Response response = httpClient.newCall(requestBuilder.build()).execute();
+      response = httpClient.newCall(requestBuilder.build()).execute();
       assert response.body() != null;
       if (!response.isSuccessful()) {
         Error error = this.objectMapper.readValue(response.body().string(), Error.class);
@@ -77,9 +86,14 @@ public BooleanEvaluationResponse evaluateBoolean(EvaluationRequest request) {
       return this.objectMapper.readValue(response.body().string(), BooleanEvaluationResponse.class);
     } catch (IOException e) {
       throw new RuntimeException(e);
+    } finally {
+      if (response != null) {
+        response.close();
+      }
     }
   }
 
+  @SuppressWarnings("resource")
   public BatchEvaluationResponse evaluateBatch(BatchEvaluationRequest request) {
     RequestBody body;
 
@@ -104,8 +118,10 @@ public BatchEvaluationResponse evaluateBatch(BatchEvaluationRequest request) {
       httpRequest.addHeader("Authorization", this.authenticationStrategy.getAuthorizationHeader());
     }
 
+    Response response = null;
+
     try {
-      Response response = httpClient.newCall(httpRequest.build()).execute();
+      response = httpClient.newCall(httpRequest.build()).execute();
       assert response.body() != null;
       if (!response.isSuccessful()) {
         Error error = this.objectMapper.readValue(response.body().string(), Error.class);
@@ -115,6 +131,10 @@ public BatchEvaluationResponse evaluateBatch(BatchEvaluationRequest request) {
       return this.objectMapper.readValue(response.body().string(), BatchEvaluationResponse.class);
     } catch (IOException e) {
       throw new RuntimeException(e);
+    } finally {
+      if (response != null) {
+        response.close();
+      }
     }
   }