Skip to content

feat: implement wrappers for GUI APIs #139

feat: implement wrappers for GUI APIs

feat: implement wrappers for GUI APIs #139

Triggered via pull request December 21, 2023 23:24
Status Failure
Total duration 1m 6s
Artifacts

lints.yml

on: pull_request
crates  /  Clippy (MSRV)
41s
crates / Clippy (MSRV)
crates  /  Clippy (beta)
16s
crates / Clippy (beta)
crates  /  Intra-doc links
34s
crates / Intra-doc links
crates  /  Rustfmt
12s
crates / Rustfmt
tools  /  Clippy (MSRV)
24s
tools / Clippy (MSRV)
tools  /  Clippy (beta)
31s
tools / Clippy (beta)
tools  /  Intra-doc links
55s
tools / Intra-doc links
tools  /  Rustfmt
2s
tools / Rustfmt
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 8 warnings
unused import: `view::View`: crates/flipperzero/src/lib.rs#L15
error: unused import: `view::View` --> flipperzero/src/gui/view_dispatcher/mod.rs:15:11 | 15 | gui::{view::View, Gui}, | ^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings`
use of deprecated method `flipperzero_sys::furi::UnsafeRecord::<T>::as_ptr`: use `as_raw(&self)` instead: crates/flipperzero/src/lib.rs#L76
error: use of deprecated method `flipperzero_sys::furi::UnsafeRecord::<T>::as_ptr`: use `as_raw(&self)` instead --> flipperzero/src/dialogs/mod.rs:76:27 | 76 | self.data.as_ptr(), | ^^^^^^ | = note: `-D deprecated` implied by `-D warnings`
field `callbacks` is never read: crates/flipperzero/src/lib.rs#L10
error: field `callbacks` is never read --> flipperzero/src/gui/view.rs:10:5 | 8 | pub struct View<C: ViewCallbacks> { | ---- field in this struct 9 | inner: ViewInner, 10 | callbacks: NonUniqueBox<C>, | ^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings`
constant `NONE` is never used: crates/flipperzero/src/lib.rs#L24
error: constant `NONE` is never used --> flipperzero/src/gui/view_dispatcher/mod.rs:24:11 | 24 | const NONE: u32 = 0xFFFFFFFF; | ^^^^
constant `IGNORE` is never used: crates/flipperzero/src/lib.rs#L27
error: constant `IGNORE` is never used --> flipperzero/src/gui/view_dispatcher/mod.rs:27:11 | 27 | const IGNORE: u32 = 0xFFFFFFFE; | ^^^^^^
struct `UnsendUnsync` is never constructed: crates/flipperzero/src/lib.rs#L25
error: struct `UnsendUnsync` is never constructed --> flipperzero/src/internals.rs:25:19 | 25 | pub(crate) struct UnsendUnsync(*const ()); | ^^^^^^^^^^^^
methods `as_non_null` and `to_box` are never used: crates/flipperzero/src/lib.rs#L153
error: methods `as_non_null` and `to_box` are never used --> flipperzero/src/internals.rs:153:23 | 151 | impl<T: ?Sized> NonUniqueBox<T> { | ------------------------------- methods in this implementation 152 | #[inline(always)] 153 | pub(crate) fn as_non_null(&self) -> NonNull<T> { | ^^^^^^^^^^^ ... 169 | pub(crate) fn to_box(self) -> Box<T> { | ^^^^^^
you should consider adding a `Default` implementation for `DialogMessage<'a>`: crates/flipperzero/src/lib.rs#L88
error: you should consider adding a `Default` implementation for `DialogMessage<'a>` --> flipperzero/src/dialogs/mod.rs:88:5 | 88 | / pub fn new() -> Self { 89 | | let data = unsafe { NonNull::new_unchecked(sys::dialog_message_alloc()) }; 90 | | 91 | | Self { ... | 94 | | } 95 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` help: try adding this | 86 + impl<'a> Default for DialogMessage<'a> { 87 + fn default() -> Self { 88 + Self::new() 89 + } 90 + } |
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: crates/flipperzero/src/lib.rs#L169
error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> flipperzero/src/internals.rs:169:30 | 169 | pub(crate) fn to_box(self) -> Box<T> { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
unsafe function's docs miss `# Safety` section: crates/flipperzero/src/lib.rs#L101
error: unsafe function's docs miss `# Safety` section --> flipperzero/src/xbm.rs:101:5 | 101 | pub unsafe fn from_raw(width: u8, height: u8, data: *const u8) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `-D clippy::missing-safety-doc` implied by `-D warnings`
crates / Clippy (beta)
clippy-action doesn't have permissions to view Check Runs, disabling!
crates / Clippy (beta)
Resource not accessible by integration
tools / Clippy (MSRV)
clippy-action doesn't have permissions to view Check Runs, disabling!
tools / Clippy (MSRV)
Resource not accessible by integration
tools / Clippy (beta)
clippy-action doesn't have permissions to view Check Runs, disabling!
tools / Clippy (beta)
Resource not accessible by integration
crates / Clippy (MSRV)
clippy-action doesn't have permissions to view Check Runs, disabling!
crates / Clippy (MSRV)
Resource not accessible by integration