Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFRFID: Fix Detection Conflict Between Securakey and Noralsy Format #4125

Merged
merged 2 commits into from
Feb 24, 2025
Merged

LFRFID: Fix Detection Conflict Between Securakey and Noralsy Format #4125

merged 2 commits into from
Feb 24, 2025

Conversation

zinongli
Copy link
Contributor

@zinongli zinongli commented Feb 22, 2025 •
edited by skotopes
Loading

What's new

Verification

  • Write this Noralsy tag to a t5 and read. Previously if you wiggle the tag around and try to tear off, on the debug log there could be false detections as Securkey occasionally.
  • With this PR it won't happen.
    Test_Nora.zip

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

skotopes
skotopes previously approved these changes Feb 24, 2025
View reviewed changes
@skotopes skotopes merged commit 9f5e93b into flipperdevices:dev Feb 24, 2025
11 checks passed
@zinongli zinongli deleted the securakey_fix branch February 25, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinongli @skotopes