Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-2754, FL-3945] EM4305 support #4069

Merged
merged 14 commits into from
Feb 12, 2025
Merged

[FL-2754, FL-3945] EM4305 support #4069

merged 14 commits into from
Feb 12, 2025

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Jan 16, 2025 •
edited by skotopes
Loading

What's new

  • Internal support for writing to EM4305 blanks
  • Support for writing EM4100, Electra, Viking, and Gallagher data to EM4305 blanks
  • This PR does not introduce support for writing other data formats to EM4305 blanks yet, it only lays the internal groundwork, other formats can now be added on an individual basis.
  • Fix EM4305 write support #2274

Verification

  • Try writing existing data formats to a T5577 tag, check that everything works as it did before.
  • Try writing EM4100/Electra/Viking/Gallagher dumps to a EM4305 tag, check that everything gets written and read correctly.
  • Try writing unsupported dumps to a EM4305 tag, they should have no effect.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Astrrra Astrrra changed the title [FL-2754] EM4305 Support [FL-2754] EM4305 internal support Jan 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PVS-Studio report for commit 4cc3bbb9:

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Compiled f7 firmware for commit bea5adce:

@Astrrra Astrrra mentioned this pull request Jan 16, 2025
Closed
skotopes
skotopes requested changes Jan 16, 2025
View reviewed changes
@Astrrra Astrrra changed the title [FL-2754] EM4305 internal support [FL-2754, FL-3945] EM4305 internal support Jan 24, 2025
@Astrrra Astrrra changed the title [FL-2754, FL-3945] EM4305 internal support [FL-2754, FL-3945] EM4305 support Jan 24, 2025
@jmaxxz jmaxxz mentioned this pull request Jan 27, 2025
Open
@skotopes skotopes merged commit 00f287e into dev Feb 12, 2025
11 checks passed
@skotopes skotopes deleted the astra/2754-em4305 branch February 12, 2025 18:04
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Feb 13, 2025
@skotopes @RogueMaster
[FL-2754, FL-3945] EM4305 support (flipperdevices#4069)
066190b 
* Initial EM4305 write support
* Support for writing EM4100 data to EM4305 blank tags
* F18 API version bump
* Satisfy pvs
* Lib: cleanup em4305 code
* Mask size fix
* Electra
* Fix leftovers from a previous implementation
* Viking
* Gallagher
* LFRFID: cleanup em4305

Co-authored-by: あく <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EM4305 write support
2 participants
@Astrrra @skotopes