Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing T5577 page 1 block count macro #3864

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Publishing T5577 page 1 block count macro #3864

merged 2 commits into from
Sep 2, 2024

Conversation

zinongli
Copy link
Contributor

@zinongli zinongli commented Aug 31, 2024 •
edited by skotopes
Loading

What's new

  • The header file used to only include page 0 count as a macro. I wish to make both page 0 and 1 block count out of the .c and available for external use. And perhaps we could gradually phase out the old macro LFRFID_T5577_BLOCK_COUNT created 2 years ago.

Verification

  • Nothing much. Just publishing a macro for external app usage.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

skotopes
skotopes previously approved these changes Sep 2, 2024
View reviewed changes
@skotopes skotopes merged commit 5272eb7 into flipperdevices:dev Sep 2, 2024
11 checks passed
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@zinongli @skotopes @ofabel
Publishing T5577 page 1 block count macro (flipperdevices#3864)
a508e31 
* publishing t5577 page 1 block count macro

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zinongli @skotopes