Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Optional Data Dependency #10

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Support for Optional Data Dependency #10

merged 4 commits into from
Sep 19, 2022

Conversation

bageshwar
Copy link
Collaborator

Additional improvements to logging

Copy link

@Kaustavd Kaustavd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@@ -105,7 +132,7 @@ BiMap<DataAdapterKey<?>, Class<? extends IDataBizlogic<?>>> getDataAdapterMap()
}

@VisibleForTesting
Multimap<Class<? extends IBizlogic>, DataAdapterKey<?>> getDataDependencyMap() {
Multimap<Class<? extends IBizlogic>, DataDependencyDetail> getDataDependencyMap() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some change in contract?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, though this method is visible only to tests.

Copy link

@Kaustavd Kaustavd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bageshwar bageshwar merged commit 00660e6 into main Sep 19, 2022
@bageshwar bageshwar deleted the reliance branch September 19, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants