Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Airflow]Fix remote log handler bug #174

Merged
merged 6 commits into from
Nov 25, 2021

Conversation

aqua7regia
Copy link
Contributor

What is the purpose of the change

Fix #172

Brief change log

  • Change the log_relative_path in remote log handler like S3, GCS, Azure when they init the context.
  • Add get_provider_info.py to pass airflow test cases.
  • Modified old test case in providers.

Verifying this change

This change has modified old test case to fit these new remote log handlers.

Copy link
Contributor

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas
Copy link
Contributor

@aqua7regia , thanks for your contribution. I have checked all the log handlers and you missed the CloudwatchTaskHandler and ElasticsearchTaskHandler. Please add these handlers into this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #174 (c6be2a5) into master (723afa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   59.37%   59.37%           
=======================================
  Files         169      169           
  Lines       13027    13027           
  Branches     1684     1684           
=======================================
  Hits         7735     7735           
  Misses       4868     4868           
  Partials      424      424           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723afa8...c6be2a5. Read the comment docs.

@wuchaochen wuchaochen merged commit 1bc5d58 into flink-extended:master Nov 25, 2021
Sxnan pushed a commit that referenced this pull request Feb 9, 2022
Add batch train batch predict example with AirFlow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Airflow] The remote logging supports the current log mechanism
4 participants