Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tizen devices fixes #1703

Merged
merged 10 commits into from
Sep 20, 2024
8 changes: 3 additions & 5 deletions packages/sdk-tizen/src/deviceManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export const launchTizenEmulator = async (name: string | true): Promise<boolean>
const devices_lines = devices.split('\n');

const allDownloadedEmulators = emulators.split('\n'); // all tizen, tizenwatch and tizenmobile emulators

const specificEmulators = await getSubplatformDevices(allDownloadedEmulators, c.platform as string);
const devicesArr = devices_lines.slice(1).map((line: string) => line.split(' ')[0]); // devices array with only their ip

Expand All @@ -100,15 +99,14 @@ export const launchTizenEmulator = async (name: string | true): Promise<boolean>

name = chosenEmulator;
}

if (name) {
if (name && typeof name === 'string') {
const ipRegex = /^(?:\d{1,3}\.){3}\d{1,3}:\d{1,5}$/;
if (name !== true && ipRegex.test(name)) {
if (ipRegex.test(name)) {
// if ip is chosen, real device boot should start
logInfo('Connecting to device');
c.runtime.target = name.split(':')[0];
await runTizenSimOrDevice();
return true;
return new Promise(() => logInfo('Device is launched.'));
}
try {
await executeAsync(
Expand Down
6 changes: 5 additions & 1 deletion packages/template-starter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,5 +133,9 @@
"browserslist": [
">0.2%",
"op_mini all"
]
],
"dependencies": {
"dotenv": "16.4.5",
"raf": "3.4.1"
}
}
Loading