Fix(iOS:Splash): Harness app splash screen #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on crazycodeboy/react-native-splash-screen#610 (comment) It seems to work now when no metro server gets found, but the problem is that it does not work in any other case...
… to be set in Xcode" This reverts commit 1312e3c.
|
splash screen (black screen) appears when app is open, but if I click "Show SplashScreen" -> nothing happens RPReplay_Final1715673574.mov |
That could be because of this - crazycodeboy/react-native-splash-screen#610 . We already use the solution listed in the comments, so if it does not work, then this means it is a package issue. Should I remove the test case for now because of it? |
|
Splash screen on ios device works when app is loading but doesn't work when test case on app-harness is clicked |
pauliusguzas
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Screenshots
Edit (7th May), as of now screen still appears black, but if the build fails screen is no longer just white, correct splash is shown...