Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webos support #1340

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Upgrade webos support #1340

merged 5 commits into from
Jan 18, 2024

Conversation

Marius456
Copy link
Contributor

@Marius456 Marius456 commented Jan 14, 2024

Description

  • Upgrade webos emulator support to simulator

Related issues

Npm releases

n/a

@Marius456 Marius456 self-assigned this Jan 14, 2024
@mihaiblaga89 mihaiblaga89 self-requested a review January 15, 2024 07:55
@mihaiblaga89 mihaiblaga89 self-assigned this Jan 15, 2024
@pauliusguzas
Copy link
Collaborator

npx rnv run -p webos -t NAME works on real webos device

@mihaiblaga89
Copy link
Contributor

@Marius456 I guess it's because I have an old CLI. We'll need to check this beforehand and error if we see a version < 1.12 (i think 1.12, please check when sim was introduced) After updating it worked fine, kinda. More on this below.

ares-launch ERR! Please check arguments

Error: Command failed with exit code 255: /opt/webOS_TV_SDK/CLI/bin/ares-launch -s 22 /Users/lego/work/renative/packages/app-harness/platformBuilds/harness_webos
ares-launch ERR! Please check arguments
    at makeError (/Users/lego/work/renative/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/Users/lego/work/renative/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
❯ /opt/webOS_TV_SDK/CLI/bin/ares-launch -V
Version: 1.11.2-j36-k

Another thing we could do is add a message saying something like "If you encounter an 'is damaged and cannot be opened' error make sure you run this command xattr -c /opt/webOS_TV_SDK/Simulator/webOS_TV_23_Simulator_1.3.0/webOS_TV_23_Simulator_1.3.0.app", with the according path for easy copy paste. This happened to me and 1) LG's mention about it is at the bottom of the page and 2) they specify xattr -cr which at least on macos I've seen that -r is not recognized

@mihaiblaga89 mihaiblaga89 merged commit 7578ea5 into release/1.0 Jan 18, 2024
1 check passed
@pavjacko pavjacko deleted the feat/upgrade_webos_support branch February 14, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants