Merge pull request #1555 from flexn-io/fix/missing_android_sdk

Fix missing dependency
flexn-io · May 21, 2024 · fbeefbb · fbeefbb
2 parents c681256 + c9d829c
commit fbeefbb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 12 deletions.
diff --git a/packages/config-templates/renative.templates.json b/packages/config-templates/renative.templates.json
@@ -2506,6 +2506,9 @@
             "version": "5.3.1",
             "web": {}
         },
+        "dotenv": {
+            "version": "16.4.5"
+        },
         "react-native-gesture-handler": {
             "version": "2.14.1",
             "android": {

diff --git a/packages/sdk-android/src/__tests__/deviceManager.test.ts b/packages/sdk-android/src/__tests__/deviceManager.test.ts
@@ -136,17 +136,18 @@ describe('resetAdb', () => {
 });
 
 describe('connectToWifiDevice', () => {
-    //TODO need to update it to add pairing functionality
-    // it('fail when connect to faulty IP address', async () => {
-    //     //GIVEN
-    //     jest.mocked(execCLI).mockResolvedValue("failed to connect to '1.1.1.1:5555': Operation timed out");
-    //     //WHEN
-    //     const result = await deviceManager.connectToWifiDevice('1.1.1.1');
-
-    //     //THEN
-    //     expect(execCLI).toHaveBeenCalledTimes(1);
-    //     expect(result).toBeFalsy();
-    // });
+    it('fail when connect to faulty IP address', async () => {
+        //GIVEN
+        jest.mocked(execCLI).mockResolvedValue(
+            "Connection refused: failed to connect to '1.1.1.1:5555': Operation timed out"
+        );
+        //WHEN
+        const result = await deviceManager.connectToWifiDevice('1.1.1.1');
+
+        //THEN
+        expect(execCLI).toHaveBeenCalledTimes(1);
+        expect(result).toBeFalsy();
+    });
     it('pass when connect to correct IP address', async () => {
         //GIVEN
         jest.mocked(execCLI).mockResolvedValue('connected to 1.1.1.1:5555');

diff --git a/packages/template-starter/renative.template.json b/packages/template-starter/renative.template.json
@@ -75,7 +75,8 @@
                 "@rnv/adapter": "1.0.0-rc.19",
                 "@rnv/config-templates": "1.0.0-rc.19",
                 "babel-loader": "9.1.3",
-                "readable-stream": "4.5.2"
+                "readable-stream": "4.5.2",
+                "dotenv": "16.4.5"
             },
             "browserslist": {
                 "production": [