Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and package.xml to 0.7.0 #547

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Aug 20, 2021

Following #532 and after checking with @scpeters and @SeanCurtis-TRI I think we are ready to run a new fcl version, 0.7.0.

I've included everything I found in v0.6.1...master in the Changelog.
Fixes #532


This change is Reviewable

@sherm1 sherm1 self-assigned this Sep 8, 2021
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-rivero!
+@sherm1 for a cursory review
:lgtm: with one minor comment

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @j-rivero)


CHANGELOG.md, line 3 at r1 (raw file):

## FCL 0

### FCL 0.7.0 (2021-08-xx)

nit: 2021-09-xx now

@j-rivero
Copy link
Contributor Author

j-rivero commented Sep 9, 2021

nit: 2021-09-xx now

Thanks @sherm1 ! I've set the release date to today.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll merge this now. What else do we need to do to complete the 0.7.0 release?

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @j-rivero)

@sherm1 sherm1 merged commit df2702c into flexible-collision-library:master Sep 9, 2021
@j-rivero
Copy link
Contributor Author

j-rivero commented Sep 9, 2021

OK, I'll merge this now. What else do we need to do to complete the 0.7.0 release?

Thanks Michael. We need to run a new release in github. Going probably to https://github.com/flexible-collision-library/fcl/releases/new , Following previous release, we can use v0.7.0 as the tag, FCL 0.7.0 as tittle, and in the summary maybe just copy paste the Changelog.

@sherm1
Copy link
Member

sherm1 commented Sep 9, 2021

@scpeters is working on that. Current question is whether the version tag should be 0.7.0 or v0.7.0. Any opinion @j-rivero?

@j-rivero
Copy link
Contributor Author

j-rivero commented Sep 9, 2021

@scpeters is working on that. Current question is whether the version tag should be 0.7.0 or v0.7.0. Any opinion @j-rivero?

I think that it would be good to follow the previous schema. Said that, I looked into the releases and tags again and seems like only the 0.6.1 was done using the prefix v but there is also a 0.6.1 tag without prefix. With this, probably the best option is back to use 0.7.0 without v. Thanks @sherm1 , @scpeters

@sherm1
Copy link
Member

sherm1 commented Sep 9, 2021

OK, thanks @j-rivero -- I'll publish the release with tag 0.7.0 tomorrow unless anyone objects. We can always add a v0.7.0 tag to the same commit later if anyone cares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release tag
2 participants