Win support #530
Merged
Win support #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual studio does not support "not".
|
There are a few other instances of this, see https://github.com/flexible-collision-library/fcl/search?q=not%28FCL_HAVE_OCTOMAP%29&type= . I don't know if it could make sense to fix all of them. |
5 tasks
|
Sounds good, I'll fix the other instances tomorrow. |
|
Okay, this is ready for review. |
sherm1
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
+@sherm1 for review
Reviewed 1 of 1 files at r1, 8 of 8 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Tobias-Fischer)
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual studio does not support "not".
This change is