Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'diverged' to SimulationData and the hdf5 attributes #97

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Adding 'diverged' to SimulationData and the hdf5 attributes #97

merged 2 commits into from
Nov 30, 2021

Conversation

momchil-flex
Copy link
Collaborator

No description provided.

tylerflex
tylerflex requested changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log a warning if diverged on line 877 yea. Then you can rebase and merge

@momchil-flex momchil-flex merged commit dfeef91 into develop Nov 30, 2021
@momchil-flex
Copy link
Collaborator Author

I left a TODO in the dispersion warning to add a link to a relevant documentation page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momchil-flex @tylerflex