Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out-of-bounds TFSF surfaces #903

Merged
merged 1 commit into from
May 25, 2023
Merged

Out-of-bounds TFSF surfaces #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

### Fixed
- A bug in a total-field scattered-field (TFSF) validator which was causing unnecessary errors when a TFSF surface intersected with 2D materials.

## [2.2.1] - 2023-5-23

Expand Down
4 changes: 4 additions & 0 deletions tidy3d/components/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,10 @@ def _validate_tfsf_structure_intersections(self) -> None:
sidewall_structs = []
# get the structures that intersect each sidewall
for surface in tfsf_surfaces:
# ignore the sidewall surface if it falls outside the simulation domain
if not self.intersects(surface):
continue

if surface.name[-2] != "xyz"[source.injection_axis]:
sidewall_surfaces.append(surface)
intersecting_structs = self.intersecting_structures(
Expand Down