add multi-pole Drude medium #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Nov 5, 2021
tidy3d/__init__.py
Outdated
| @@ -17,7 +17,16 @@ | |||
| from .components import Box, Sphere, Cylinder, PolySlab | |||
|
|
|||
| # medium | |||
| from .components import Medium, PoleResidue, Sellmeier, Debye, Lorentz, AnisotropicMedium, PEC | |||
| from .components import ( | |||
There was a problem hiding this comment.
Can we break this up into two lines:
from .components import Medium, PoleResidue ...
from .components import Drude, ...just to avoid it splitting into several lines like this.
There was a problem hiding this comment.
It's been fixed now.
tylerflex
requested changes
Nov 5, 2021
There was a problem hiding this comment.
Just fix that formatting comment and I'll merge. Thanks @weiliangjin2021 !
|
That's also a good practice for you to rebase, squash the commit with this small change, and git push -f to override! |
break lines
e53ab60 to
9211011
Compare
tylerflex
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Drude Model #67