Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eps_model eval at td.inf if freq is None #317

Merged
merged 4 commits into from
Apr 19, 2022
Merged

eps_model eval at td.inf if freq is None #317

merged 4 commits into from
Apr 19, 2022

Conversation

tylerflex
Copy link
Collaborator

Makes this explicit and fixes nan coming from inf * 0 in PoleResidue

@tylerflex tylerflex requested review from momchil-flex and weiliangjin2021 and removed request for momchil-flex April 18, 2022 23:14
@weiliangjin2021
Copy link
Collaborator

When frequency_range is not None, mat.eps_model(None) will return (nan+nanj). Is this expected?

@tylerflex
Copy link
Collaborator Author

no, it's not expected. thanks. I'll have to look into that again.

@tylerflex
Copy link
Collaborator Author

what was the frequency range where you observe this? I guess if eps_model(None) implies freq=inf, so we should be able to handle in principle if the frequency bounds upper limit is inf.

@weiliangjin2021
Copy link
Collaborator

The material is BK7_Zemax, so the frequency bound is finite.

@tylerflex tylerflex merged commit aa49e12 into develop Apr 19, 2022
@tylerflex tylerflex deleted the tyler/plot_eps_none branch April 19, 2022 20:05
daquinteroflex pushed a commit to daquinteroflex/tidy3d that referenced this pull request Nov 7, 2023
@e-g-melo
FAQ broken links update (flexcompute#317)
19c015b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiliangjin2021 weiliangjin2021 weiliangjin2021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerflex @weiliangjin2021