Slanted PolySlab implementation #258
Conversation
There was a problem hiding this comment.
impressive work. I am not able to follow all of the math, but the testing coverage seems good and I trust it all works. Thanks @weiliangjin2021 Can you just make sure to answer my few comments and make sure that the docstring descriptions have periods after them so everything looks the same in the docs?
Let's also make sure that we run a few notebooks that use poly slabs and ensure they are working properly when tidy3d is switched to this branch.
| ) | ||
|
|
||
| # remove duplicate neighbouring vertices, and orient in CCW direction | ||
| vertices = PolySlab._proper_vertices(val) |
There was a problem hiding this comment.
this gets applied to val, not val_np and then it seems vertices is never used besides validation (the val_np is returned). Is this expected?
There was a problem hiding this comment.
it is expected. They are only used in validation.
|
feel free to rebase and merge when you think it's well tested on some of the notebooks. For example, add a slight sidewall to |
aa64cc5 to
aa25add
Compare
More Validators for PolySlab to make sure the base polygon is valid Validator to make sure no vertices crossing during extrusion with sidewall Change "inside" function in geometry to include boundaries Implement itersection_side for slanted PolySlab
aa25add to
40a9337
Compare
More Validators for PolySlab to make sure the base polygon is valid
Validator to make sure no vertices crossing during extrusion with sidewall
Change "inside" function in geometry to include boundaries
Implement itersection_side for slanted PolySlab