-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
% Done Monitoring #241
% Done Monitoring #241
Conversation
issue #140 |
This is pretty decent for tasks that take longer than a minute. I'm down to merge - is there any specific testing you have in mind? Let's check in with Lei again about making the solver_progress.csv available earlier than after 100s. Just one thing maybe to fix, this ran to 32% before early shutoff, but then it shows 100% done. Should we fix that? |
Yea I think it marks the progress bar as "complete" when it's done running. I dont know if it would be more confusing to leave like this or to change it to end at 32% (potentially making people think the job didn't finish). What do you think? |
No specific testing in mind, just wanted to get another pair of eyes on it. |
I feel like given that this is the full output, it won't be confusing, and it would provide the extra information about at what point the shutoff happened. |
Ok I pushed this fix. If it's no longer running but the |
Alright Lei pushed the change to get solver_progress in the first 10s. I tried a simulation that took 33s total and it worked pretty well! OK to merge as far as I'm concerned. |
Also, in old tidy3d, in the monitor function, we do something like |
ok my last commit should do it, I refactored out the |
…photonic_crystals Alec/photonic crystals
So this is looking pretty good on the front end, but needs some testing and a bit of refinement.
How it works now:
Simplifies a lot.
Job uses web.monitor() now.
Remaining issues: