feature[design]: allow design plugin to interface with pytorch via Result #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converting now to a PR since the notebook PR is out |
There was a problem hiding this comment.
Thanks @groberts-flex the accessors definitely are a great addition!
ce8bc51 to
9a166b0
Compare
|
Thanks @groberts-flex I think this is good to go implementation-wise, but still needs tests and a changelog entry. For the tests, I think the accessor methods can be tested easily (check |
86a8d2b to
eaa243f
Compare
|
tests and changelog entry are in, how does this look for merging @yaugenst-flex? |
yaugenst-flex
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Thanks @groberts-flex I think this looks good, only a minor comment.
0fb2b3f to
f0af5b7
Compare
f0af5b7 to
06c33fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the design plugin wherein the optimization method returns the dimensions in a different order and so labeling with the
self.dimsparameter can end up being incorrect.It also implements accessor and length functions for the Result class so that it can be used directly as a Dataset in PyTorch. This also may be useful generally.
Marking this as a draft for now to discuss if we want to make these changes to the plugin. The changes are currently needed for the surrogate notebooks draft PR. (flexcompute/tidy3d-notebooks#228)