-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ Review fixes #2180
⚡ Review fixes #2180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daquinteroflex for being on top of this. I'll finish the rest of the comments on Monday, when I'll probably have Daniil's feedback
|
looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is getting nit-picky but some of the docstrings still sound unnecessarily verbose to me :)
f0f72a5
to
f9dd9ba
Compare
b25c165
to
e137a2a
Compare
Thanks everyone for your comments. I have addressed all of them. I will merge this branch. Any additional comments can be dealt with in #2077 |
Re #2077 review.
MultiPhysicsMedium
silicon library.