Reduce complex tolerance in mode solver #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0bf4c6c to
3d5ab93
Compare
weiliangjin2021
approved these changes
Jan 17, 2025
3d5ab93 to
3d99501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for a waveguide with conductivity than about 1e-8, our mode solver returns
k_eff=0. This is due to the complex tolerance set tofp_epsregardless of requested precision.I propose we reduce the complex tolerance to 1e-10 for both precisions. This is what I get then:
Alternative is to set it based on precision. However, first of all this requires some refactor as it is currently a unique constant, and the
ModeSpec.precisionwill need to be passed around. Second, as shown above, keeping it lower thanfp_epseven for single precision makes even single-precision simulations accurate for some of the scanned range.