feat[frontend]: add angle validator to specify expected angle in radians #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thanks @groberts-flex, looks great! Don't forget the changelog though, even if it's a small change.
tidy3d/components/geometry/base.py
Outdated
| upper_bound = np.pi / 2 | ||
| if (value <= lower_bound) or (value >= upper_bound): | ||
| raise ValidationError( | ||
| f"sidewall angle ({value}) must be between {lower_bound} and {upper_bound} rad" |
There was a problem hiding this comment.
Capitalization and punctuation :)
Other than that, should we consider just writing between -π/2 and π/2 rad maybe? Don't think this bound is going to change, and the message would be even clearer.
There was a problem hiding this comment.
Thanks for the catch! And yes, I like that idea and updated the string!
daquinteroflex
approved these changes
Jan 15, 2025
eda6972 to
7861fdb
Compare
7861fdb to
11fe1e5
Compare
11fe1e5 to
cc7dc6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a clearer validation message that the expected units for the
sidewall_anglefield are in radians to explain why the range is between +/- pi/2.