Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move min_steps_per_sim_size to the end of args list in auto for back-compatibility #2158

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Move min_steps_per_sim_size to the end of args list in auto for back-compatibility #2158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tidy3d/components/grid/grid_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,11 +900,11 @@ def auto(
cls,
wavelength: pd.PositiveFloat = None,
min_steps_per_wvl: pd.PositiveFloat = 10.0,
min_steps_per_sim_size: pd.PositiveFloat = 10.0,
max_scale: pd.PositiveFloat = 1.4,
override_structures: List[StructureType] = (),
snapping_points: Tuple[Coordinate, ...] = (),
dl_min: pd.NonNegativeFloat = 0.0,
min_steps_per_sim_size: pd.PositiveFloat = 10.0,
mesher: MesherType = GradedMesher(),
) -> GridSpec:
"""Use the same :class:`AutoGrid` along each of the three directions.
Expand All @@ -927,6 +927,8 @@ def auto(
A set of points that enforce grid boundaries to pass through them.
dl_min: pd.NonNegativeFloat
Lower bound of grid size.
min_steps_per_sim_size : pd.PositiveFloat, optional
Minimal number of steps per longest edge length of simulation domain.
mesher : MesherType = GradedMesher()
The type of mesher to use to generate the grid automatically.

Expand Down
Loading