Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Bump JAX version for numpy 2 compatibility #2146

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

yaugenst-flex
Copy link
Collaborator

Currently potentially leads to invalid env as per #1913 (comment)

Copy link

Copy link
Collaborator

@daquinteroflex daquinteroflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to decide if we need to do a new release

@yaugenst-flex
Copy link
Collaborator Author

@momchil-flex adding you as a reviewer because of the release question. this is going into develop right now

@momchil-flex
Copy link
Collaborator

@dmarek-flex was the issue restricted to trying to use our jax plugin, or was it somehow manifesting even without that?

If restricted to the jax plugin we're probably fine... If anyone complains in the meantime we can tell them to upgrade jax.

@dmarek-flex
Copy link
Contributor

@dmarek-flex was the issue restricted to trying to use our jax plugin, or was it somehow manifesting even without that?

For me the issue manifested when running the quickstart notebook, since optax uses jax.

@dmarek-flex
Copy link
Contributor

Everything seems to be working as expected! In case it matters I found that on develop numpy>=2 will be installed in a fresh environment, while on pre/2.8 numpy <2 is installed. I think that is what happened to my environment, switching between branches and running the poetry install commands updated my numpy version.

@momchil-flex momchil-flex merged commit eeec869 into develop Jan 10, 2025
15 checks passed
@momchil-flex momchil-flex deleted the yaugenst-flex/bump-jax branch January 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants