Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ElectromagneticFieldData._check_fields_stored #2122

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

momchil-flex
Copy link
Collaborator

@momchil-flex momchil-flex commented Dec 13, 2024

This appears in some FieldData checks but was only implemented for ModeData and ModeSolverData.

Copy link
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'm not sure where the other implementations were. Have they been removed from Mode*Data?

@momchil-flex
Copy link
Collaborator Author

Looks fine. I'm not sure where the other implementations were. Have they been removed from Mode*Data?

No, as each has a different error message...

@momchil-flex momchil-flex merged commit f1587f4 into pre/2.8 Dec 13, 2024
15 checks passed
@momchil-flex momchil-flex deleted the momchil/check_fields branch December 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants