Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytorch version because <=2.1 does not have cpuonly py312 wheels #2118

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

yaugenst-flex
Copy link
Collaborator

No description provided.

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/bump-pytorch branch from cce91bb to 7de043e Compare December 11, 2024 15:51
Copy link
Collaborator

@daquinteroflex daquinteroflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder why the torch-cpu source is explicit and if this makes a difference rather than supplemental, but looks correct anyway since it works.

@yaugenst
Copy link
Contributor

yaugenst commented Dec 12, 2024

Because supplemental packages are only pulled if no other higher-priority channel (i.e. PyPI in our case) can satisfy the requirements, and pytorch is distributed on PyPI with cuda builds (which we don't want). Explicit forces that specific source for the package if the package is requested. At least I think that's how it works :D

@momchil-flex momchil-flex merged commit 860da71 into pre/2.8 Dec 12, 2024
15 checks passed
@momchil-flex momchil-flex deleted the yaugenst-flex/bump-pytorch branch December 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants