Run the mode solver through the regular webapi functions #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerflex pinging you because of the web api mocking changes |
tylerflex
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
all of the fixtures were copied in here from other tests?
we really need to re-do these web api tests :). I also am really confused how they work.
dbochkov-flexcompute
approved these changes
Dec 11, 2024
70bb9ff to
b640098
Compare
b640098 to
5e58418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2090 : rebased to pre/2.8 and fixed tests and added a new testcase.