MeshOverrideStructure only Box #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
853c559 to
9ecd908
Compare
momchil-flex
reviewed
Dec 6, 2024
tidy3d/components/structure.py
Outdated
| if not isinstance(val, Box): | ||
| log.warning( | ||
| "Override structures should be 'Box' as of 'tidy3d' version 2.8. " | ||
| f"Given type of '{type(val)}'. Converting to bounding box." |
There was a problem hiding this comment.
How about Given type of '{type(val)}, using '{type(val)}.bounding_box' instead.? Just as an extra hint to the user that if they pass geometry.bounding_box in their override structure definition they can avoid the warning.
tomflexcompute
approved these changes
Dec 6, 2024
9ecd908 to
1cee826
Compare
1cee826 to
3df6d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2105