Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better plot_grid #2097

Merged
merged 1 commit into from
Dec 3, 2024
Merged

better plot_grid #2097

merged 1 commit into from
Dec 3, 2024

Conversation

tylerflex
Copy link
Collaborator

uses axhline and axvline to Draw grid boundaries. and ignores grid boundaries for size 0 dims.

https://matplotlib.org/stable/api/_as_gen/matplotlib.axes.Axes.axhline.html

before
image

after
image

@tylerflex tylerflex force-pushed the tyler/fix/plot_grid branch from 53cfbc3 to 29bf835 Compare December 2, 2024 19:24
@tylerflex tylerflex changed the base branch from develop to pre/2.8 December 2, 2024 19:25
@tylerflex tylerflex force-pushed the tyler/fix/plot_grid branch from 29bf835 to 2e3807b Compare December 2, 2024 19:26
@tylerflex tylerflex force-pushed the tyler/fix/plot_grid branch from 2e3807b to 6c7144b Compare December 2, 2024 19:27
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, code looks much better!

@momchil-flex momchil-flex merged commit 79c495a into pre/2.8 Dec 3, 2024
15 checks passed
@momchil-flex momchil-flex deleted the tyler/fix/plot_grid branch December 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants