Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify interp validator #2096

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Simplify interp validator #2096

merged 1 commit into from
Dec 3, 2024

Conversation

yaugenst-flex
Copy link
Collaborator

Changes the interp validator to only check for duplicate coordinates instead of explicitly interpolating and selecting and added a test.

Seems to be catching the same validation errors as before, but not 100% sure.

@yaugenst-flex yaugenst-flex added the 2.8 will go into version 2.8.* label Nov 28, 2024
@yaugenst-flex yaugenst-flex self-assigned this Nov 28, 2024
@yaugenst-flex
Copy link
Collaborator Author

This change is copied over from #2087

momchil-flex
momchil-flex approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, all the cases that I know of that were problematic it was because of duplicated coordinates, if we encounter other cases in the future we'll have to expand this validator.

marc-flex
marc-flex approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@marc-flex marc-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks for taking care of this!

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/interp-validator branch from cc589f2 to f2e4f17 Compare December 2, 2024 14:34
@yaugenst-flex yaugenst-flex merged commit 6fe6bd8 into pre/2.8 Dec 3, 2024
15 checks passed
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/interp-validator branch December 3, 2024 07:39
@momchil-flex momchil-flex mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

@marc-flex marc-flex marc-flex approved these changes

Assignees

@yaugenst-flex yaugenst-flex

Labels
2.8 will go into version 2.8.*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaugenst-flex @momchil-flex @marc-flex