Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter Tests #207

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Stricter Tests #207

merged 5 commits into from
Feb 14, 2022

Conversation

tylerflex
Copy link
Collaborator

Tox tests now check for

  • clean lint.
  • clean diff from black

Blacked code using updated black, adds spacing around **

@tylerflex tylerflex changed the title Tyler/strict tests Stricter Tests Feb 11, 2022
@momchil-flex
Copy link
Collaborator

So we gotta make sure everyone is using the same - or at least somewhat consistent - version of black? We should not this down somewhere explicitly.

@tylerflex
Copy link
Collaborator Author

@momchil-flex
Copy link
Collaborator

Seems like the checks don't pass?

@momchil-flex
Copy link
Collaborator

momchil-flex commented Feb 14, 2022

I think the only reason they don't pass is because of this tidy3d/components/monitor.py:159:18: W0612: Unused variable 'tind_end' (unused-variable). I'm a bit confused, seems like it runs the tests on the code state that would happen after a merge with develop, as this issue comes from the latest develop commit.

This is generally good to know actually, it's better if the tests are run that way.

@tylerflex
Copy link
Collaborator Author

yea this is a typo. Let me fix and see if the tests run again

@tylerflex tylerflex merged commit 91807c0 into develop Feb 14, 2022
@tylerflex tylerflex deleted the tyler/strict_tests branch March 25, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants