Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add s3 config to download_file call. #2060

Merged

Conversation

pperanich
Copy link
Contributor

Adding _s3_config specified in s3utils into the download_file call, similar to upload_fileobj.

@momchil-flex
Copy link
Collaborator

@magiWei could you take a look?

Copy link
Collaborator

@lei-flex lei-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. ship it.

@momchil-flex momchil-flex merged commit 27720fc into flexcompute:develop Nov 8, 2024
@yaugenst-flex
Copy link
Collaborator

Hi @pperanich,

Thanks for your contribution! I was wondering if you could provide some context on why you added the S3 config to the download_file call. Was there a specific issue or necessity on your end that prompted this change?

Just trying to understand the motivation so we can ensure everything is aligned properly. Appreciate your insights!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants