Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEC structures do not affect colorbar in plot_eps #205

Merged
merged 1 commit into from
Feb 11, 2022
Merged

PEC structures do not affect colorbar in plot_eps #205

merged 1 commit into from
Feb 11, 2022

Conversation

tylerflex
Copy link
Collaborator

before, adding a PEC would change the colorbar in plot_eps to include tidy3d.constants.pec_val now it does not.

@tylerflex
Copy link
Collaborator Author

I also changed so PEC plots gold with black outline in simulation.plot() feel free to change back if you dont agree.

@tylerflex tylerflex requested a review from momchilmm February 9, 2022 22:15
@tylerflex tylerflex mentioned this pull request Feb 10, 2022
Closed
@tylerflex tylerflex requested review from shashwat-sh and removed request for momchilmm February 11, 2022 00:07
@tylerflex tylerflex merged commit 90a5ac0 into develop Feb 11, 2022
@tylerflex tylerflex deleted the tyler/plot_fix branch February 11, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashwat-sh shashwat-sh shashwat-sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerflex @shashwat-sh