Replace infinite coordinates for shapely operation #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
approved these changes
Oct 11, 2024
3e38fb5 to
df8aafd
Compare
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
df8aafd to
ff25fd3
Compare
|
Thanks, just rebased to add this to the 2.7.5 changelog and fix one linting issue. By the way the pre-commit hook ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug described in https://github.com/flexcompute/tidy3d-core/issues/726
The added test is the minimal failure case I could find, but to be honest, I'm not 100% sure why it fails in this instance when other shapes with infinite coordinates worked fine in shapely.