fix autograd bug re: inclusion extraneous field mnts #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3e6106 to
acebc79
Compare
yaugenst-flex
approved these changes
Oct 1, 2024
yaugenst-flex
approved these changes
Oct 1, 2024
acebc79 to
1b3d385
Compare
|
fixed values() iteration but still am not able to reproduce this error. (basically the test I added passes even without the change) would be good (but not super high priority) to understand why exactly this popped up and reproduce it in a test |
Merged
|
yeah I also can't reproduce it. I think it's because emulated run does not exactly reproduce what is happening in regular run, because the code will fail is using regular run |
|
Merging but this would need further investigation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still not sure:
this isn't triggered by regular autograd code. might be something with the metrics