Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure.from_permittivity_array #1972

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tylerflex
Copy link
Collaborator

Fixes #1971

Open to changing the name Structure.from_custom_data since it technically just creates structure from custom permittivity data? maybe it could be generalized?

But basically I think this will simplify some adjoint demos so would be good to have in 2.7.4

@tylerflex tylerflex requested review from momchil-flex and yaugenst-flex and removed request for momchil-flex September 23, 2024 10:53
Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice this is really useful. I think the name is fine in principle. To be a bit more explicit, maybe something like .from_permittivity_array()?

@tylerflex tylerflex force-pushed the tyler/structure/from_custom_data branch 2 times, most recently from e5f7a0e to 41fb3c4 Compare September 23, 2024 11:54
@tylerflex
Copy link
Collaborator Author

from_permittivity_array

Sounds good.

BTW implemented in an example here
flexcompute/tidy3d-notebooks#173

@tylerflex tylerflex force-pushed the tyler/structure/from_custom_data branch from 41fb3c4 to 7956f1e Compare September 23, 2024 12:03
@tylerflex
Copy link
Collaborator Author

@yaugenst-flex made name change here and in notebook

@tylerflex tylerflex changed the title Structure.from_custom_data Structure.from_permittivity_array Sep 24, 2024
@tylerflex tylerflex added 2.7 will go into version 2.7.* .4 labels Sep 24, 2024
@momchil-flex
Copy link
Collaborator

Approved, ideally the procedure should be rebase and merge notebook PR -> update notebook submodule state here to develop -> rebase and merge this one.

@tylerflex tylerflex force-pushed the tyler/structure/from_custom_data branch from 7956f1e to 7038d8a Compare September 24, 2024 08:06
@tylerflex
Copy link
Collaborator Author

rebase and merge notebook PR -> update notebook submodule state here to develop -> rebase and merge this one.

done, I'll merge when the tests pass again

@tylerflex tylerflex merged commit 543917f into develop Sep 24, 2024
15 checks passed
@tylerflex tylerflex deleted the tyler/structure/from_custom_data branch September 24, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.* .4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convenience method for creating CustomMedium
3 participants