Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializable invdes postprocessing #1959

Merged

Conversation

yaugenst-flex
Copy link
Collaborator

@yaugenst-flex yaugenst-flex commented Sep 15, 2024

Is this roughly what you had in mind @tylerflex?

This is branched off of #1848
Closes #1943

@yaugenst-flex yaugenst-flex self-assigned this Sep 15, 2024
@yaugenst-flex yaugenst-flex changed the base branch from develop to yaugenst-flex/serializable-ops September 15, 2024 07:22
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/invdes-postprocess branch 2 times, most recently from 0aa5a06 to 70cc331 Compare September 15, 2024 21:58
@tylerflex
Copy link
Collaborator

Yea this is pretty much exactly what I had in mind.

@yaugenst-flex
Copy link
Collaborator Author

ok nice I'll fix the tests and wrap this up then

@tylerflex
Copy link
Collaborator

How would this work with InverseDesignMulti?

@yaugenst-flex
Copy link
Collaborator Author

yeah I have to check that. I think it might just work? will test

@tylerflex
Copy link
Collaborator

Each simulation will need its own post process function. So i guess maybe a list of them is needed. But seems kind of clunky at first glance.

@yaugenst-flex
Copy link
Collaborator Author

how does this currently work? doesn't the optimizer.run() take only a single fn?

@tylerflex
Copy link
Collaborator

It does but the function takes the batch data as arguments (i think, it might also take the individual simulation data's as args too). Check the last couple cells of the main tutorial Invdes.ipynb (on mobile)

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/invdes-postprocess branch from 70cc331 to 115b399 Compare September 16, 2024 11:36
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/invdes-postprocess branch from 750d6c4 to ae9030f Compare September 17, 2024 12:49
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/serializable-ops branch from 3fb6c51 to ff01229 Compare September 17, 2024 12:51
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/invdes-postprocess branch from ae9030f to 8e63be7 Compare September 17, 2024 12:55
@yaugenst-flex yaugenst-flex marked this pull request as ready for review September 17, 2024 12:56
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/invdes-postprocess branch from 8e63be7 to 6fb432a Compare September 17, 2024 13:00
@yaugenst-flex yaugenst-flex merged commit 3c3ec11 into yaugenst-flex/serializable-ops Sep 18, 2024
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/invdes-postprocess branch September 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration of serializable expressions as post-processing option for invdes
2 participants