-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed angle simulations #1954
Fixed angle simulations #1954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a little clarification for beginners like me would be helpful!
8685f0e
to
1cf8d85
Compare
7f13f2b
to
a107cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. thanks @dbochkov-flexcompute ! Just a few minor comments but other than that, good to merge.
c242868
to
b197759
Compare
b197759
to
e603d46
Compare
Summary of changes:
angular_spec
inPlaneWave
, which can take valuesFixedAngleSpec()
andFixedInPlaneKSpec()
. Those are currently empty specs, but in future we could add parameters to them.FixedAngleSpec()
due to a new stability criterionFixedAngleSpec()
/FixedInPlaneKSpec()
orConstAngleSpec()
/ConstInPlaneKSpec()
example notebook https://github.com/flexcompute/tidy3d-notebooks/blob/daniil/fixed-angle/AngularFrequencyDependence.ipynb