Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed angle simulations #1954

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fixed angle simulations #1954

merged 2 commits into from
Dec 11, 2024

Conversation

dbochkov-flexcompute
Copy link
Contributor

@dbochkov-flexcompute dbochkov-flexcompute commented Sep 11, 2024

Summary of changes:

  • introduced field angular_spec in PlaneWave, which can take values FixedAngleSpec() and FixedInPlaneKSpec(). Those are currently empty specs, but in future we could add parameters to them.
  • automatic time step reduction for FixedAngleSpec() due to a new stability criterion
  • minor change in diffraction monitor data, so that results can be processed at multiple bloch vectors simultaneously
  • btw, do you prefer FixedAngleSpec()/FixedInPlaneKSpec() or ConstAngleSpec()/ConstInPlaneKSpec()

example notebook https://github.com/flexcompute/tidy3d-notebooks/blob/daniil/fixed-angle/AngularFrequencyDependence.ipynb

@momchil-flex momchil-flex added the 2.8 will go into version 2.8.* label Sep 17, 2024
Copy link
Contributor

@dmarek-flex dmarek-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a little clarification for beginners like me would be helpful!

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. thanks @dbochkov-flexcompute ! Just a few minor comments but other than that, good to merge.

@momchil-flex momchil-flex added the rc1 1st pre-release label Dec 6, 2024
@tylerflex tylerflex linked an issue Dec 6, 2024 that may be closed by this pull request
@momchil-flex momchil-flex merged commit 29b34d4 into pre/2.8 Dec 11, 2024
15 checks passed
@momchil-flex momchil-flex deleted the daniil/fixed-angle branch December 11, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 will go into version 2.8.* rc1 1st pre-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadband fixed angle source (BFAST) support
4 participants