Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug that replaced all lumped elements in simulations, when using TerminalComponentModeler #1953

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

dmarek-flex
Copy link
Contributor

Just had to copy any existing lumped elements before adding loads from the ports.

@dmarek-flex dmarek-flex self-assigned this Sep 9, 2024
@dmarek-flex dmarek-flex added the 2.8 will go into version 2.8.* label Sep 10, 2024
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yea, this can be a tricky one. I often wonder if some kind of append: bool argument to updated_copy() might be useful for some things. For example, it would be a shortcut to doing list(self.field) + list(new_things). maybe some other time.

@dmarek-flex dmarek-flex merged commit 865889d into pre/2.8 Sep 11, 2024
15 checks passed
@dmarek-flex dmarek-flex deleted the dmarek/fix-ovewrite-lumped-elements branch September 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.8 will go into version 2.8.*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants