Adding Sellmeier.from_dispersion() #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
reviewed
Feb 2, 2022
|
|
||
| if dn_dwvl > 0: | ||
| raise ValidationError("Dispersion ``dn_dwvl`` must be smaller than zero.") | ||
| if n < 1: |
There was a problem hiding this comment.
based on description of the error, should this be n <= 1?
There was a problem hiding this comment.
applies to one above too
There was a problem hiding this comment.
Good catch, technically the conditions are correct and the descriptions should change, but I'm gonna require dn_dwvl to be strictly smaller than zero because it could trigger an error if it's exactly zero due to numerical precision. I'll update.
26f3050 to
2a13235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.