Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More autograd improvements #1914

Merged
merged 4 commits into from
Aug 22, 2024
Merged

More autograd improvements #1914

merged 4 commits into from
Aug 22, 2024

Conversation

tylerflex
Copy link
Collaborator

Introduces a set of additional improvements to autograd plugin:

  1. PolySlab grad monitor data is only stored on the plane where needed.
  2. Validate FWD sim, even when it's a server-side run.
  3. Properly handle error if no adjoint sources are present and add a more useful fix.

Let me know if you'd like this merged int #1891 for one PR? But would be good to include both in a 2.7.3

@tylerflex tylerflex added 2.7 will go into version 2.7.* .3 labels Aug 21, 2024
@tylerflex tylerflex changed the title Tyler/autograd /cleanup1 More autograd improvements Aug 21, 2024
Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(also, I'm in favor of small PR)

@tylerflex tylerflex merged commit 0d3d462 into develop Aug 22, 2024
15 checks passed
@tylerflex tylerflex deleted the tyler/autograd_/cleanup1 branch August 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.* .3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants