Dilation support for JaxPolySlab
#1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4179d7 to
4e4fd31
Compare
4e4fd31 to
7df70d0
Compare
tylerflex
reviewed
Aug 20, 2024
7df70d0 to
c576119
Compare
c576119 to
05a3e9a
Compare
tylerflex
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Feel free to merge @yaugenst-flex when you're ready. no rush
05a3e9a to
74dff54
Compare
74dff54 to
60bd74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic support for
dilationargument inJaxPolySlab.This also enables differentiation w.r.t. dilation, but note that this currently only works if no sidewall angle is present (see tests). Actually differentiating w.r.t. everything works (i.e.,
dilation,sidewall_angle, andslab_bounds) as long as there is no / very little sidewall angle.