Momchil/various #190
Merged
Momchil/various #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
629263a to
1a0290e
Compare
tylerflex
reviewed
Jan 31, 2022
| @@ -253,7 +253,6 @@ def generate_docstring(cls) -> str: | |||
| # if the model already has a docstring, get the first lines and save the rest | |||
| original_docstrings = [] | |||
| if cls.__doc__: | |||
| original_docstring = cls.__doc__.replace(" ", "\t") | |||
There was a problem hiding this comment.
hm. so does this fix something?
There was a problem hiding this comment.
Was an unused variable caught by pylint
tylerflex
reviewed
Jan 31, 2022
| @@ -848,7 +848,8 @@ def at_centers(self, field_monitor_name: str) -> xr.Dataset: | |||
|
|
|||
| @equal_aspect | |||
| @add_ax_if_none | |||
| def plot_field( # pylint:disable=too-many-arguments, too-many-locals | |||
| # pylint:disable=too-many-arguments, too-many-locals, too-many-branches, too-many-statements | |||
There was a problem hiding this comment.
Yup, summarizes how I feel about this method :D
tylerflex
reviewed
Jan 31, 2022
| @@ -913,8 +914,8 @@ def plot_field( # pylint:disable=too-many-arguments, too-many-locals | |||
| if field_name == "int": | |||
| monitor_data = self.at_centers(field_monitor_name) | |||
| xr_data = 0.0 | |||
| for field_name in ("Ex", "Ey", "Ez"): | |||
| field_data = monitor_data[field_name] | |||
| for field in ("Ex", "Ey", "Ez"): | |||
There was a problem hiding this comment.
again, pylint caught that :)
tylerflex
reviewed
Jan 31, 2022
| try: | ||
| import matplotlib as mpl | ||
| from mpl_toolkits.axes_grid1 import make_axes_locatable | ||
| except Exception: # pylint: disable=broad-except |
There was a problem hiding this comment.
hm, this is probably not great practice. do you think eventually we can find a solution?
There was a problem hiding this comment.
Yes, eventually...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.