Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add units to IndexPerturbation.frequency #1868

Merged
merged 1 commit into from
Aug 5, 2024
Merged

add units to IndexPerturbation.frequency #1868

merged 1 commit into from
Aug 5, 2024

Conversation

tylerflex
Copy link
Collaborator

@tylerflex tylerflex requested review from dbochkov-flexcompute and daquinteroflex and removed request for dbochkov-flexcompute July 31, 2024 15:24
@tylerflex tylerflex added 2.7 will go into version 2.7.* .2 labels Aug 2, 2024
daquinteroflex
daquinteroflex approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@daquinteroflex daquinteroflex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Curious as to whether they will run into more issues with any more fields throughout the API classes if they don't have units too.

@tylerflex tylerflex merged commit f1b299e into develop Aug 5, 2024
16 checks passed
@tylerflex tylerflex deleted the tyler/fix/units_index_perturbation branch August 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daquinteroflex daquinteroflex daquinteroflex approved these changes

Assignees
No one assigned
Labels
2.7 will go into version 2.7.* .2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerflex @daquinteroflex