Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the use of dielectrics only in RectangularDielectric #1859

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Validate the use of dielectrics only in RectangularDielectric #1859

merged 1 commit into from
Jul 29, 2024

Conversation

lucas-flexcompute
Copy link
Collaborator

This will give a better error message if the user tries to set metallic materials when using the RectangularDielectric class.

@lucas-flexcompute
Validate the use of dielectrics only in RectangularDielectric
5b7dc7f 
Signed-off-by: Lucas Heitzmann Gabrielli <lucas@flexcompute.com>
tomflexcompute
tomflexcompute approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucas-flexcompute !

@lucas-flexcompute lucas-flexcompute merged commit b08633c into pre/2.8 Jul 29, 2024
16 checks passed
@lucas-flexcompute lucas-flexcompute deleted the lucas/waveguide_plugin/metallic_error branch July 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@tomflexcompute tomflexcompute tomflexcompute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucas-flexcompute @tylerflex @tomflexcompute