Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated validator for 2D far field projection to include FieldProjectionCartesianMonitor #1850

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Updated validator for 2D far field projection to include FieldProjectionCartesianMonitor #1850

merged 1 commit into from
Aug 5, 2024

Conversation

QimingFlex
Copy link
Contributor

@QimingFlex QimingFlex commented Jul 22, 2024 •
edited
Loading

Thanks to comments from @yaugenst-flex , the verbosity of the code has been greatly reduced. It's now ready for a final review by @momchil-flex .

@QimingFlex QimingFlex force-pushed the qiming/2d_car_farfield branch 2 times, most recently from 4dcfaf7 to 63de12a Compare August 2, 2024 18:44
@QimingFlex QimingFlex requested a review from tylerflex August 2, 2024 18:45
@tylerflex tylerflex requested a review from yaugenst-flex August 2, 2024 19:21
tylerflex
tylerflex approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QimingFlex

yaugenst-flex
yaugenst-flex approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only a minor comment regarding the validation.

@QimingFlex QimingFlex force-pushed the qiming/2d_car_farfield branch from 63de12a to eeb736f Compare August 5, 2024 12:51
@QimingFlex QimingFlex marked this pull request as ready for review August 5, 2024 12:58
@QimingFlex QimingFlex force-pushed the qiming/2d_car_farfield branch 3 times, most recently from 6724ba3 to 6e88bd6 Compare August 5, 2024 14:39
@momchil-flex momchil-flex force-pushed the qiming/2d_car_farfield branch from 6e88bd6 to d3ef09c Compare August 5, 2024 17:54
@momchil-flex momchil-flex force-pushed the qiming/2d_car_farfield branch from d3ef09c to 4bdc2a3 Compare August 5, 2024 17:55
@momchil-flex momchil-flex merged commit 3de1e67 into develop Aug 5, 2024
1 check passed
@momchil-flex momchil-flex deleted the qiming/2d_car_farfield branch August 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@yaugenst-flex yaugenst-flex yaugenst-flex approved these changes

@momchil-flex momchil-flex Awaiting requested review from momchil-flex

@weiliangjin2021 weiliangjin2021 Awaiting requested review from weiliangjin2021

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QimingFlex @tylerflex @yaugenst-flex @momchil-flex