-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added plot_units to simulation and scene classes #1811
Conversation
06945c9
to
8f7469c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmarek-flex! This will definitely be nice to have
5675d3b
to
24bd077
Compare
24bd077
to
e38eb20
Compare
@tylerflex any idea why that set of tests failed? |
Probably something doesn't like the μ. |
potentially related to the regex? https://github.com/flexcompute/tidy3d/blob/develop/scripts/make_script.py#L69 |
@yaugenst-flex the more the merrier. I thought maybe you had changed make_script.py recently, but I think that was just the formatting commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very helpful for now. Hopefully later we can set global units for time, length, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Yeah make_script.py
got formatted and I did some minor refactoring, didn't touch the actual functionality. There is currently a problem with generating scripts from simulations that contain DataArray
s, but that's a bit tricky to sort out.
57ad93d
to
8dcaf4c
Compare
While working in the RF world I have been manually modifying plots so that the axes look good. But it is probably best to add that ability directly to tidy3d. I added an optional parameter to the Simulation and Scene classes that will automatically set the axes labels and title, along with a proper scaling of the tick labels.
Here is an example without setting plot_units:
And here when using "mm":