Fixed docstrings for directivitydata and custom source #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b48bb4d to
729ad10
Compare
yaugenst-flex
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks for the fix! Looks good to me. We can maybe consider for some examples to include # doctest: +SKIP to just skip the test if we want to avoid setting up simulations and such in examples, that might make sense in cases where the setup is very cumbersome. Here it still seems fine though.
|
Yeah, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed docstrings for both directivitydata and the custom source. Could you @momchil-flex double check if the custom source example make scene?